Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: custom selection color text and background #874

Merged
merged 2 commits into from
Jun 26, 2023
Merged

feat: custom selection color text and background #874

merged 2 commits into from
Jun 26, 2023

Conversation

arin-paliwal
Copy link
Contributor

@arin-paliwal arin-paliwal commented Jun 20, 2023

closes #861

Changes Made

I added the functionality of selecting text with the color theme of the overall website
I have tested the functionality and it is working properly and is not depreciating any other feature

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, @arin-paliwal, thank you for opening a pull request.

Soon the maintainers/owner will review it and provide you with feedback/suggestions.
If you think it's something urgent, feel free to reach out to Tamal on Twitter.


Give us a ⭐ to show some support
Happy OpenSource 🚀

@github-actions github-actions bot added the deployed This PR has been deployed to Vercel for testing. label Jun 20, 2023
@tamalCodes
Copy link
Member

Hi @arin-paliwal , you were supposed to follow the Pull request guidelines and also please from the next time do not modify the pull REQUEST template. It is there for a reason. Please fix the PR as the bot suggests.

@arin-paliwal
Copy link
Contributor Author

I am writing the PR again as per given format

@github-actions
Copy link

This pull request has been deployed to Vercel.

Latest commit: b0954d3
✅ Preview: https://milan-8cqkhgpj2-iamtamal.vercel.app
🔍 Inspect: https://vercel.com/iamtamal/milan/Hp7GU6tsBZodeRcd5UB3Ywt5auf2

View Workflow Logs

@tamalCodes
Copy link
Member

Hi please delete the update the very first comment, you don't need to write it again. Just update the first one.
You can delete the last one & also update the PR title.

Use something like feat: (remove the brackets and write what you did in very short)

@arin-paliwal arin-paliwal changed the title Custom Selection Color for Text feat: Implemented custom selection color for selecting text Jun 25, 2023
@arin-paliwal arin-paliwal changed the title feat: Implemented custom selection color for selecting text feat: custom selection color text and background Jun 25, 2023
@arin-paliwal
Copy link
Contributor Author

Hi please delete the update the very first comment, you don't need to write it again. Just update the first one. You can delete the last one & also update the PR title.

Use something like feat: (remove the brackets and write what you did in very short)

I have changed it

@tamalCodes tamalCodes self-requested a review June 26, 2023 04:17
Copy link
Member

@tamalCodes tamalCodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing work !

The changes look good to me and will be merged soon.

Do follow Tamal for more Opensource fun projects and don't forget to drop a star so that you get updated about our latest releases (we will tag you and mention your work) and also a shoutout on social media (LinkedIn and Twitter) !

Happy Opensource 🚀.

@tamalCodes tamalCodes added status: ready ✅ This PR has passed all the checks and is now ready to be merged. area/ui This issue is related to frontend/interface fix. 💡 feature This generally contains addition/changes to features. gssoc23 This issue/PR is part of GSSOC'23. level2 GSSOC 23 -> LEVEL 2 labels Jun 26, 2023
@tamalCodes tamalCodes merged commit a3a1889 into ngoworldcommunity:main Jun 26, 2023
8 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ui This issue is related to frontend/interface fix. deployed This PR has been deployed to Vercel for testing. 💡 feature This generally contains addition/changes to features. gssoc23 This issue/PR is part of GSSOC'23. level2 GSSOC 23 -> LEVEL 2 status: ready ✅ This PR has passed all the checks and is now ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Text Selection Style to Match Website Theme
2 participants