Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: primary theme for site with vendor prefix #909

Merged
merged 3 commits into from
Jul 5, 2023
Merged

feat: primary theme for site with vendor prefix #909

merged 3 commits into from
Jul 5, 2023

Conversation

0xabdulkhalid
Copy link
Contributor

@0xabdulkhalid 0xabdulkhalid commented Jun 29, 2023

Related Issue

Closes: #894

Changes made πŸ‘·πŸ»β€β™‚οΈ

  • Introduced navigation bar theme facility with vendor prefixes, this ensures to perform for all devices like mac, windows & android as we expected.
  • The primary color #E26959 is used as Primary theme.
  • This feature has various advantages some of them are below,
    • Consistent branding across devices and platforms.
    • Enhanced user experience tailored to different devices.
    • Visual appeal and standout appearance.

@github-actions github-actions bot added πŸ’‘ feature This generally contains addition/changes to features. status: todo ⏳ This issue is yet to be seen by the maintainer of the project. 🐞 bug This is a patch, generally fixing some bugs. labels Jun 29, 2023
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, @0xabdulkhalid, thank you for opening a pull request.

Soon the maintainers/owner will review it and provide you with feedback/suggestions.
If you think it's something urgent, feel free to reach out to Tamal on Twitter.


Give us a ⭐ to show some support
Happy OpenSource πŸš€

@github-actions github-actions bot temporarily deployed to Preview June 29, 2023 16:18 Inactive
@github-actions github-actions bot added the deployed This PR has been deployed to Vercel for testing. label Jun 29, 2023
@0xabdulkhalid
Copy link
Contributor Author

Please review this PR @tamalCodes.

@tamalCodes tamalCodes added area/accessibility This issue is related to an accessiblity fix. gssoc23 This issue/PR is part of GSSOC'23. level1 GSSOC 23 -> LEVEL 1 and removed status: todo ⏳ This issue is yet to be seen by the maintainer of the project. labels Jul 5, 2023
@github-actions
Copy link

github-actions bot commented Jul 5, 2023

This pull request has been deployed to Vercel.

Latest commit: e31b7d5
βœ… Preview: https://milan-ablogeix0-iamtamal.vercel.app
πŸ” Inspect: https://vercel.com/iamtamal/milan/BYymGqnvb4D6wy11bKwLvZgV3cVm

View Workflow Logs

@tamalCodes tamalCodes merged commit 9eccb9c into ngoworldcommunity:main Jul 5, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/accessibility This issue is related to an accessiblity fix. 🐞 bug This is a patch, generally fixing some bugs. deployed This PR has been deployed to Vercel for testing. πŸ’‘ feature This generally contains addition/changes to features. gssoc23 This issue/PR is part of GSSOC'23. level1 GSSOC 23 -> LEVEL 1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE]: ADD PROPER THEME COLOR
2 participants