Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: added navbar closing when clicking navlinks #922

Merged

Conversation

anamika7153
Copy link
Contributor

Related Issue

Closes: #912

Changes made πŸ‘·πŸ»β€β™‚οΈ

  • I have fixed the issue that was preventing the navbar to close when the Navlinks are clicked on mobile devices. Now navbar closes as soon as that Navlink is clicked and the requested page is displayed.

@github-actions github-actions bot added status: todo ⏳ This issue is yet to be seen by the maintainer of the project. 🐞 bug This is a patch, generally fixing some bugs. labels Jul 5, 2023
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, @anamika7153, thank you for opening a pull request.

Soon the maintainers/owner will review it and provide you with feedback/suggestions.
If you think it's something urgent, feel free to reach out to Tamal on Twitter.


Give us a ⭐ to show some support
Happy OpenSource πŸš€

@github-actions github-actions bot temporarily deployed to Preview July 5, 2023 11:13 Inactive
@github-actions
Copy link

github-actions bot commented Jul 5, 2023

This pull request has been deployed to Vercel.

Latest commit: fbf574e
βœ… Preview: https://milan-9q0nfy0un-iamtamal.vercel.app
πŸ” Inspect: https://vercel.com/iamtamal/milan/AF6JoGkcmK3smAuFbcEamCmc3U9M

View Workflow Logs

@github-actions github-actions bot added the deployed This PR has been deployed to Vercel for testing. label Jul 5, 2023
@tamalCodes tamalCodes added status: wip πŸ‘©πŸ»β€πŸ’» This issue/PR is actively being worked on. gssoc23 This issue/PR is part of GSSOC'23. level1 GSSOC 23 -> LEVEL 1 and removed status: todo ⏳ This issue is yet to be seen by the maintainer of the project. labels Jul 6, 2023
Copy link
Member

@tamalCodes tamalCodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing work !

The changes look good to me and will be merged soon.

Do follow Tamal for more Opensource fun projects and don't forget to drop a star so that you get updated about our latest releases (we will tag you and mention your work) and also a shoutout on social media (LinkedIn and Twitter) !

Happy Opensource πŸš€.

@tamalCodes tamalCodes added status: ready βœ… This PR has passed all the checks and is now ready to be merged. and removed status: wip πŸ‘©πŸ»β€πŸ’» This issue/PR is actively being worked on. labels Jul 6, 2023
@tamalCodes tamalCodes merged commit 979b6d2 into ngoworldcommunity:main Jul 6, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug This is a patch, generally fixing some bugs. deployed This PR has been deployed to Vercel for testing. gssoc23 This issue/PR is part of GSSOC'23. level1 GSSOC 23 -> LEVEL 1 status: ready βœ… This PR has passed all the checks and is now ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Navbar remains open after clicking links on mobile
2 participants