Unpack agent release #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous release code produced a 'release.json' that contained raw binaries rather than zip archives containing the agent. Changing those binaries to zip archives doesn't exactly work, leading to errors like: ``` exec: ngrok: Exec format error ``` This adds an unpack phase to give us the appropriate format. Now, a natural question to ask is "why not use fetchTarball instead of fetchurl, it unzips files for you?" The answer to that is that our release.json is generated with the sha of the zip file, but fetchTarball needs the unpacked sha of the directory tree (nix-prefetch-url --unpack). Internally, we _can_ derive that, but it's currently easier to use the sha of the artifact we download directly, partly because other release mechanisms (brew, etc) expect the zip's sha too. I also don't think there's any significant difference between the two options. We'll have to re-run the release job to actually pick up this change, but this should let it build and push correct docker images.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous release code produced a 'release.json' that contained raw
binaries rather than zip archives containing the agent.
Changing those binaries to zip archives doesn't exactly work, leading to
errors like:
This adds an unpack phase to give us the appropriate format.
Now, a natural question to ask is "why not use fetchTarball instead of
fetchurl, it unzips files for you?"
The answer to that is that our release.json is generated with the sha of
the zip file, but fetchTarball needs the unpacked sha of the directory
tree (nix-prefetch-url --unpack).
Internally, we can derive that, but it's currently easier to use the
sha of the artifact we download directly, partly because other release
mechanisms (brew, etc) expect the zip's sha too.
I also don't think there's any significant difference between the two
options.
We'll have to re-run the release job to actually pick up this change,
but this should let it build and push correct docker images.