fix(component-store): effect handles generics that extend upon a type (…

…#3485)

Closes #3482

modules/component-store/spec/types/regression.spec.ts

@@ -0,0 +1,44 @@
+import { expecter } from 'ts-snippet';
+import { compilerOptions } from './utils';
+
+describe('regression component-store', () => {
+  const expectSnippet = expecter(
+    (code) => `
+        import { ComponentStore } from '@ngrx/component-store';
+        import { of, EMPTY, Observable } from 'rxjs';
+        import { concatMap } from 'rxjs/operators';
+
+        ${code}
+      `,
+    compilerOptions()
+  );
+
+  it('https://github.com/ngrx/platform/issues/3482', () => {
+    const effectTest = `
+        interface SomeType {
+          name: string;
+          prop: string;
+        }
+
+        export abstract class MyStore<
+          QueryVariables extends SomeType
+        > extends ComponentStore<any> {
+          protected abstract readonly query$: Observable<Omit<QueryVariables, 'name'>>;
+
+          readonly load = this.effect(
+            (origin$: Observable<Omit<QueryVariables, 'name'> | null>) => origin$
+          );
+
+          protected constructor() {
+            super();
+          }
+
+          protected initializeLoad() {
+            // 👇 this should work
+            this.load(this.query$);
+          }
+        }
+      `;
+    expectSnippet(effectTest).toSucceed();
+  });
+});

modules/component-store/src/component-store.ts

@@ -291,7 +291,9 @@ export class ComponentStore<T extends object> implements OnDestroy {
     ObservableType = OriginType extends Observable<infer A> ? A : never,
     // Return either an optional callback or a function requiring specific types as inputs
     ReturnType = ProvidedType | ObservableType extends void
-      ? (observableOrValue?: void | Observable<void>) => Subscription
+      ? (
+          observableOrValue?: ObservableType | Observable<ObservableType>
+        ) => Subscription
       : (
           observableOrValue: ObservableType | Observable<ObservableType>
         ) => Subscription