fix(router-store): include string[] as return type for selectQueryPar…

…am (#4369)
ngrx · May 31, 2024 · b0b43f7 · b0b43f7
1 parent 1a1b6df
commit b0b43f7
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/modules/router-store/spec/types/router_selectors.types.spec.ts b/modules/router-store/spec/types/router_selectors.types.spec.ts
@@ -53,7 +53,7 @@ describe('getRouterSelectors', () => {
     );
   });
 
-  it('selectQueryParam should return string', () => {
+  it('selectQueryParam should return string or string[]', () => {
     expectSnippet(`
       export const selectIdFromRoute = selectQueryParam('id')
       export const selector = createSelector(
@@ -62,7 +62,7 @@ describe('getRouterSelectors', () => {
       );
     `).toInfer(
       'selector',
-      'MemoizedSelector<State, string, (s1: string) => string>'
+      'MemoizedSelector<State, string | string[], (s1: string | string[]) => string | string[]>'
     );
   });
 

diff --git a/modules/router-store/src/models.ts b/modules/router-store/src/models.ts
@@ -5,7 +5,9 @@ export type RouterStateSelectors<V> = {
   selectCurrentRoute: MemoizedSelector<V, any>;
   selectFragment: MemoizedSelector<V, string | undefined>;
   selectQueryParams: MemoizedSelector<V, Params>;
-  selectQueryParam: (param: string) => MemoizedSelector<V, string | undefined>;
+  selectQueryParam: (
+    param: string
+  ) => MemoizedSelector<V, string | string[] | undefined>;
   selectRouteParams: MemoizedSelector<V, Params>;
   selectRouteParam: (param: string) => MemoizedSelector<V, string | undefined>;
   selectRouteData: MemoizedSelector<V, Data>;