Skip to content

Commit c7e1406

Browse files
EnricoVogtbrandonroberts
authored andcommitted
feat(router-store): Make usage of forRoot required (#1662) (#1672)
Closes #1662 BREAKING CHANGES: usage of forRoot is now required for StoreRouterConnectingModule BEFORE: ```ts @NgModule({ imports: [ StoreRouterConnectingModule ] }) export class AppModule {} ``` AFTER: ```ts @NgModule({ imports: [ StoreRouterConnectingModule.forRoot() ] }) export class AppModule {} ```
1 parent 57bacf5 commit c7e1406

File tree

1 file changed

+7
-18
lines changed

1 file changed

+7
-18
lines changed

modules/router-store/src/router_store_module.ts

Lines changed: 7 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -122,31 +122,15 @@ enum RouterTrigger {
122122
* { path: '', component: SimpleCmp },
123123
* { path: 'next', component: SimpleCmp }
124124
* ]),
125-
* StoreRouterConnectingModule
125+
* StoreRouterConnectingModule.forRoot()
126126
* ],
127127
* bootstrap: [AppCmp]
128128
* })
129129
* export class AppModule {
130130
* }
131131
* ```
132132
*/
133-
@NgModule({
134-
providers: [
135-
{
136-
provide: _ROUTER_CONFIG,
137-
useValue: {},
138-
},
139-
{
140-
provide: ROUTER_CONFIG,
141-
useFactory: _createRouterConfig,
142-
deps: [_ROUTER_CONFIG],
143-
},
144-
{
145-
provide: RouterStateSerializer,
146-
useClass: DefaultRouterStateSerializer,
147-
},
148-
],
149-
})
133+
@NgModule({})
150134
export class StoreRouterConnectingModule {
151135
static forRoot<
152136
T extends BaseRouterStoreState = SerializedRouterStateSnapshot
@@ -157,6 +141,11 @@ export class StoreRouterConnectingModule {
157141
ngModule: StoreRouterConnectingModule,
158142
providers: [
159143
{ provide: _ROUTER_CONFIG, useValue: config },
144+
{
145+
provide: ROUTER_CONFIG,
146+
useFactory: _createRouterConfig,
147+
deps: [_ROUTER_CONFIG],
148+
},
160149
{
161150
provide: RouterStateSerializer,
162151
useClass: config.serializer

0 commit comments

Comments
 (0)