fix(Effects): Make ofType operator strictFunctionTypes safe (#789)

Closes #753

Author: timdeschryver

modules/effects/src/actions.ts

@@ -2,7 +2,7 @@ import { Injectable, Inject } from '@angular/core';
 import { Action, ScannedActionsSubject } from '@ngrx/store';
 import { Observable } from 'rxjs/Observable';
 import { Operator } from 'rxjs/Operator';
-import { filter } from 'rxjs/operator/filter';
+import { filter } from 'rxjs/operators';
 import { OperatorFunction } from 'rxjs/interfaces';
 
 @Injectable()
@@ -23,14 +23,12 @@ export class Actions<V = Action> extends Observable<V> {
   }
 
   ofType<V2 extends V = V>(...allowedTypes: string[]): Actions<V2> {
-    return ofType<any>(...allowedTypes)(this as Actions<any>);
+    return ofType<any>(...allowedTypes)(this as Actions<any>) as Actions<V2>;
   }
 }
 
 export function ofType<T extends Action>(...allowedTypes: string[]) {
-  return function ofTypeOperator(source$: Actions<T>): Actions<T> {
-    return filter.call(source$, (action: Action) =>
-      allowedTypes.some(type => type === action.type)
-    );
-  };
+  return filter((action: Action): action is T =>
+    allowedTypes.some(type => type === action.type)
+  );
 }

modules/schematics/src/container/index.spec.ts

@@ -51,7 +51,6 @@ describe('Container Schematic', () => {
     appTree.create('/src/app/reducers', '');
     const tree = schematicRunner.runSchematic('container', options, appTree);
     const content = getFileContent(tree, '/src/app/foo/foo.component.ts');
-    console.log(content);
     expect(content).toMatch(/import\ {\ Store\ }\ from\ '@ngrx\/store';/);
   });