Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add github previews for PRs #1423

Closed
brandonroberts opened this issue Nov 13, 2018 · 0 comments · Fixed by #1426
Closed

docs: add github previews for PRs #1423

brandonroberts opened this issue Nov 13, 2018 · 0 comments · Fixed by #1426
Assignees

Comments

@brandonroberts
Copy link
Member

Other information:

I would be willing to submit a PR for the docs ❤️

[x] Yes (Assistance is provided if you need help submitting a pull request)
[ ] No

Similar to what Angular does when PRs are opened that change the docs. We should build the PR branch, and post a GitHub comment with a link to see the preview.

@brandonroberts brandonroberts self-assigned this Nov 13, 2018
brandonroberts added a commit that referenced this issue Nov 14, 2018
brandonroberts added a commit to brandonroberts/platform that referenced this issue Nov 14, 2018
brandonroberts added a commit that referenced this issue Nov 14, 2018
brandonroberts added a commit to brandonroberts/platform that referenced this issue Nov 14, 2018
brandonroberts added a commit to brandonroberts/platform that referenced this issue Nov 14, 2018
brandonroberts added a commit to brandonroberts/platform that referenced this issue Nov 14, 2018
brandonroberts added a commit to brandonroberts/platform that referenced this issue Nov 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant