Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ROOT_EFFECTS_INIT actions as ActionCreators #2219

Merged
merged 5 commits into from Nov 7, 2019
Merged

ROOT_EFFECTS_INIT actions as ActionCreators #2219

merged 5 commits into from Nov 7, 2019

Conversation

maxisam
Copy link
Contributor

@maxisam maxisam commented Nov 6, 2019

#2218

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Closes #

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[ ] No

Other information

@ngrxbot
Copy link
Collaborator

ngrxbot commented Nov 6, 2019 •
edited

Preview docs changes for 92d81a7 at https://previews.ngrx.io/pr2219-92d81a7/

@maxisam
Copy link
Contributor Author

maxisam commented Nov 6, 2019

not sure what I did wrong.

@maxisam @brandonroberts
Update modules/effects/src/effects_root_module.ts
be3ed7d 
Co-Authored-By: Brandon <robertsbt@gmail.com>
brandonroberts
brandonroberts requested changes Nov 7, 2019
View reviewed changes
Copy link
Member

@brandonroberts brandonroberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It needs to be added here to the public API also.

https://github.com/ngrx/platform/blob/master/modules/effects/src/index.ts

timdeschryver
timdeschryver requested changes Nov 7, 2019
View reviewed changes
modules/effects/src/index.ts Outdated Show resolved Hide resolved
@maxisam @timdeschryver
Update modules/effects/src/index.ts
92d81a7 
Co-Authored-By: Tim Deschryver <28659384+timdeschryver@users.noreply.github.com>
@brandonroberts brandonroberts merged commit de9a590 into ngrx:master Nov 7, 2019
@maxisam maxisam deleted the patch-1 branch November 7, 2019 17:19
@maxisam
Copy link
Contributor Author

maxisam commented Nov 7, 2019

thanks guys!

@brandonroberts
Copy link
Member

Thank you @maxisam!

jordanpowell88 pushed a commit to jordanpowell88/platform that referenced this pull request Nov 14, 2019
@maxisam @jordanpowell88
fix(effects): add action creator for root effects init action (ngrx#2219
f323808 
)

Closes ngrx#2218
@timdeschryver timdeschryver mentioned this pull request Nov 20, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timdeschryver timdeschryver timdeschryver requested changes

@brandonroberts brandonroberts brandonroberts approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@maxisam @ngrxbot @brandonroberts @timdeschryver