Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(store): Correct types for SelectorFactoryConfig #2752

Merged
merged 1 commit into from
Oct 22, 2020

Conversation

SebastianPodgajny
Copy link
Contributor

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Closes #

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

Current types

export type SelectorFactoryConfig<T = any, V = any> = {
stateFn: (
state: T,
props: any,
selectors: Selector<any, any>[],
memoizedProjector: MemoizedProjection
) => V;
};

Current usage

const memoizedState = defaultMemoize(function (state: any, props: any) {
return options.stateFn.apply(null, [
state,
selectors,
props,
memoizedProjector,
]);
});

export function defaultStateFn(
state: any,
selectors: Selector<any, any>[] | SelectorWithProps<any, any, any>[],
props: any,
memoizedProjector: MemoizedProjection
): any {

@ngrxbot
Copy link
Collaborator

ngrxbot commented Oct 20, 2020

Preview docs changes for 08d5a01 at https://previews.ngrx.io/pr2752-08d5a01e/

Copy link
Member

@timdeschryver timdeschryver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@brandonroberts brandonroberts merged commit aa9bf1a into ngrx:master Oct 22, 2020
@brandonroberts
Copy link
Member

Thanks @SebastianPodgajny!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants