Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(store): add migration for create selector generics #3237

Merged
merged 2 commits into from Nov 17, 2021

Conversation

david-shortman
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Closes #

What is the new behavior?

Migrates createSelector generics

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@ngrxbot
Copy link
Collaborator

ngrxbot commented Nov 14, 2021

Preview docs changes for c4a4f4d at https://previews.ngrx.io/pr3237-c4a4f4d4/

@@ -20,6 +20,11 @@
"description": "The road to v13 beta",
"version": "13-beta",
"factory": "./13_0_0-beta/index"
},
"ngrx-store-migration-13-0-1": {
"description": "The road to v13.0.1",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@david-shortman FYI, version 13.0.0 is not published yet. This migration should be included in v13.0.0-rc.1 or v13.0.0.

cc @brandonroberts

@brandonroberts brandonroberts changed the title feat(store) add migration for create selector generics feat(store): add migration for create selector generics Nov 16, 2021
@brandonroberts brandonroberts changed the title feat(store): add migration for create selector generics fix(store): add migration for create selector generics Nov 16, 2021
@brandonroberts brandonroberts merged commit 5d97a11 into ngrx:master Nov 17, 2021
@david-shortman david-shortman deleted the create-selector-migration branch November 17, 2021 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants