perf(component): reset state / trigger CD only if necessary

[markostanimirovic]

PR Checklist

Please check if your PR fulfills the following requirements:

• The commit message follows our guidelines: https://github.com/ngrx/platform/blob/master/CONTRIBUTING.md#commit
• Tests for the changes have been added (for bug fixes / features)
• Documentation has been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[x] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[x] Other... Please describe: Performance improvements

What is the current behavior?

1. When the first observable that emits the value synchronously arrives, the change detection will be triggered two times. This causes an error when changeDetectorRef.detectChanges is called in zoneless environment (reported in Push pipe calls detectChanges before setting value #3327).
2. When another observable that emits the value synchronously arrives, the same will happen.

Closes #3327

What is the new behavior?

For both scenarios 👆 the change detection will be triggered once. The behavior for observables that emit asynchronously will remain the same..

Does this PR introduce a breaking change?

[ ] Yes
[x] No

[netlify]

✅ Deploy Preview for ngrx-io ready!

Built without sensitive environment variables

Name	Link
🔨 Latest commit	5ae9f31
🔍 Latest deploy log	https://app.netlify.com/sites/ngrx-io/deploys/6255e6e3f03faa00085b0504
😎 Deploy Preview	https://deploy-preview-3328--ngrx-io.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site settings.

[brandonroberts]

LGTM on code, but if this changes the current behavior of two detection cycles to one, might be an unintentional breaking change for current users.

[markostanimirovic]

LGTM on code, but if this changes the current behavior of two detection cycles to one, might be an unintentional breaking change for current users.

Sure, let's postpone this change for v14.

I also have in mind a few more improvements, such as better typing for LetDirective, which would also be a breaking change.

[timdeschryver]

Nice work!

[markostanimirovic]

After playing around with the suspense template, I realized that the potential observable subscription has to be moved to the ngOnInit method in order to get initial input values on directive initialization.