Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(store): install and configure the @ngrx/eslint-plugin on ng-add #3386

Merged
merged 3 commits into from
Apr 28, 2022
Merged

feat(store): install and configure the @ngrx/eslint-plugin on ng-add #3386

merged 3 commits into from
Apr 28, 2022

Conversation

timdeschryver
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Partially #3372

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

Instead of adding the plugin manually, this PR appends the @ngrx/eslint-plugin to the ng-add tasks.

@netlify
Copy link

netlify bot commented Apr 23, 2022 •
edited

✅ Deploy Preview for ngrx-io canceled.

Name Link
🔨 Latest commit 70e1c40
🔍 Latest deploy log https://app.netlify.com/sites/ngrx-io/deploys/6263b04d3c03e20008a2b759

timdeschryver
timdeschryver commented Apr 23, 2022
View reviewed changes
modules/store/schematics/ng-add/index.ts
`);
}
const installTaskId = context.addTask(new NodePackageInstallTask());
context.addTask(new RunSchematicTask('@ngrx/eslint-plugin', 'ng-add', {}), [
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe that this should work, but to be sure I'll have to verify it once we have a beta version.

@timdeschryver timdeschryver changed the title Eslint plugin/run on store add fix(store): add @ngrx/eslint-plugin on ng-add Apr 23, 2022
@timdeschryver timdeschryver changed the title fix(store): add @ngrx/eslint-plugin on ng-add feat(store): install and configure the @ngrx/eslint-plugin on ng-add Apr 23, 2022
@brandonroberts brandonroberts merged commit bf2672e into master Apr 28, 2022
@timdeschryver timdeschryver deleted the eslint-plugin/run-on-store-add branch April 28, 2022 04:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brandonroberts brandonroberts brandonroberts approved these changes

@markostanimirovic markostanimirovic markostanimirovic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@timdeschryver @brandonroberts @markostanimirovic