Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(store): rename template literal to string literal for createActionGroup #3426

Merged

Conversation

markostanimirovic
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Template literals are subsets of string literal types. The createActionGroup function requires to use string literals for source/event names, but the error message is 'source/event name must be a template literal type'.

What is the new behavior?

Displaying correct error message when the type of source/event name is not a string literal.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

@brandonroberts
Copy link
Member

@markostanimirovic do we need to backport this fix to 13.2 also?

@brandonroberts brandonroberts merged commit 7d08db1 into ngrx:master May 24, 2022
@markostanimirovic
Copy link
Member Author

@brandonroberts I don't think it's necessary, because it fixes the error message only.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants