Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(schematics): add workingDirectory to schemas #3473

Merged
merged 2 commits into from
Jun 28, 2022

Conversation

timdeschryver
Copy link
Member

@timdeschryver timdeschryver commented Jun 28, 2022

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Closes #3469

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

Old:

 npx ng add ngrx-store-14.0.0-local
ℹ Using package manager: npm
✔ Package information loaded.

The package ngrx-store-14.0.0-local will be installed and
executed.
Would you like to proceed? Yes
✔ Packages successfully installed.
The 'path' option in 'C:\Users\timde\dev\playgrounds\ng-fourteen\node_modules\@ngrx\store\schematics\ng-add\schema.json' is using deprecated behaviour.'workingDirectory' smart default provider should be used instead.
UPDATE src/app/app.module.ts (489 bytes)
UPDATE package.json (1227 bytes)
✔ Packages installed successfully.

New:

 npx ng add ngrx-store-14.0.0-local.tgz
ℹ Using package manager: npm
✔ Package information loaded.

The package ngrx-store-14.0.0-local.tgz will be installed and
executed.
Would you like to proceed? Yes
✔ Packages successfully installed.
UPDATE src/app/app.module.ts (470 bytes)
UPDATE package.json (1223 bytes)
✔ Packages installed successfully.

@netlify
Copy link

netlify bot commented Jun 28, 2022

Deploy Preview for ngrx-io canceled.

Name Link
🔨 Latest commit da9d5ed
🔍 Latest deploy log https://app.netlify.com/sites/ngrx-io/deploys/62bb52580dafb90008cf3658

@@ -38,7 +38,7 @@ context('Full round trip', () => {
});

it('is possible to add books', () => {
cy.get('bc-book-preview').eq(2).click();
cy.get('bc-book-preview').eq(1).click();
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤦 seems like the google books API suddenly returns the same books more than once.

@brandonroberts brandonroberts merged commit 50ea6b3 into master Jun 28, 2022
@brandonroberts brandonroberts deleted the schematics/workingDirectory branch June 28, 2022 20:52
timdeschryver pushed a commit that referenced this pull request Jun 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

schematics: 'path' option is using deprecated behavior
2 participants