Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(component): replace markDirty with custom TickScheduler #3488

Conversation

markostanimirovic
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

The @ngrx/component package uses the markDirty function from the @angular/core package to mark a component as dirty and schedule tick in zone-less mode. However, this function will be removed soon.

What is the new behavior?

The markDirty function is replaced with a custom TickScheduler.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

angular/angular#46806

@netlify
Copy link

netlify bot commented Jul 13, 2022

Deploy Preview for ngrx-io canceled.

Built without sensitive environment variables

Name Link
🔨 Latest commit aa82823
🔍 Latest deploy log https://app.netlify.com/sites/ngrx-io/deploys/62df15b72985a20008e24461

@markostanimirovic
Copy link
Member Author

Copy link
Member

@timdeschryver timdeschryver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be fair, I don't know much about this, but this LGTM.

Copy link
Member

@brandonroberts brandonroberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as discussed during our sync

@brandonroberts brandonroberts merged commit 3fcd8af into ngrx:master Aug 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants