Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misnamed function in Entity #367

Closed
karptonite opened this issue Sep 10, 2017 · 0 comments
Closed

Misnamed function in Entity #367

karptonite opened this issue Sep 10, 2017 · 0 comments

Comments

@karptonite
Copy link
Contributor

I'm submitting a...


[ ] Regression (a behavior that used to work and stopped working in a new release)
[x] Bug report  
[ ] Feature request
[ ] Documentation issue or request
[ ] Support request

In the documentation for the forthcoming @ngrx/entity adapter, the createEntityAdapter function is said to take a sort function, but the example given shows it taking a compareFunction, in the form that is usually passed to a sort method. If the intention is that this should be a compare function, it should probably be renamed to avoid confusion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant