Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add ng add support for standalone config to NgRx packages #3881

Merged
merged 5 commits into from
May 8, 2023

Conversation

brandonroberts
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Closes #

What is the new behavior?

Fixed bug with syncing schematics-core across packages.

Adds ng add support for NgRx packages

ng add @ngrx/effects --standalone
ng add @ngrx/store-devtools --standalone
ng add @ngrx/router-store --standalone

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@netlify
Copy link

netlify bot commented May 8, 2023

Deploy Preview for ngrx-io ready!

Name Link
🔨 Latest commit 3dd7844
🔍 Latest deploy log https://app.netlify.com/sites/ngrx-io/deploys/6458f6f90625d500085f11cd
😎 Deploy Preview https://deploy-preview-3881--ngrx-io.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Member

@markostanimirovic markostanimirovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@DMezhenskyi
Copy link
Contributor

Looks great! 👍
I have just one question. Shouldn't be the install.md files for corresponding modules also updated on ngrx.io documentation? I am curious because the checkbox "Documentation has been added/updated" is checked but I could not see md files updated.

@brandonroberts
Copy link
Member Author

@DMezhenskyi yep, good catch. I just updated those also

@timdeschryver timdeschryver merged commit 58508e3 into master May 8, 2023
@timdeschryver timdeschryver deleted the ng-add-standalone-schematics branch May 8, 2023 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants