fix(component-store): use default equality function for selectSignal #3884
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
👷 Deploy Preview for ngrx-io processing.
|
✅ Deploy Preview for ngrx-io ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
| @@ -1500,6 +1501,60 @@ describe('Component Store', () => { | |||
| expect(projectorExecutionCount).toBe(3); | |||
| }); | |||
|
|
|||
| it('uses default equality function when equality function is not provided', () => { | |||
There was a problem hiding this comment.
Do we need a test for passing a custom equality check?
There was a problem hiding this comment.
Yes, we already have tests for a custom equality function.
brandonroberts
approved these changes
May 9, 2023
timdeschryver
approved these changes
May 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Related to #3882
Does this PR introduce a breaking change?