Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(eslint-plugin): add new avoid-mapping-component-store-selectors rule #4026

Merged

Conversation

timdeschryver
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Closes #3940

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

The first commit (61bc231) moves the spec files into directories so it becomes easier to find.

@netlify
Copy link

netlify bot commented Sep 1, 2023

Deploy Preview for ngrx-io ready!

Name Link
🔨 Latest commit ff58526
🔍 Latest deploy log https://app.netlify.com/sites/ngrx-io/deploys/650885d0d40fb20008b24e5f
😎 Deploy Preview https://deploy-preview-4026--ngrx-io.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@timdeschryver timdeschryver force-pushed the eslint-avoid-combining-component-store-selectors branch from 20fc0a9 to 7411108 Compare September 2, 2023 14:27
@timdeschryver timdeschryver force-pushed the eslint-avoid-combining-component-store-selectors branch from cc4811e to ff58526 Compare September 18, 2023 17:15
Copy link
Member

@markostanimirovic markostanimirovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@markostanimirovic markostanimirovic merged commit 40477dd into main Sep 18, 2023
6 checks passed
@markostanimirovic markostanimirovic deleted the eslint-avoid-combining-component-store-selectors branch September 18, 2023 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

eslint-plugin(component-store): avoid-mapping-selectors
4 participants