fix(signals): run rxMethod
outside of reactive context
#4224
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What is the current behavior?
It looks like the latest refactoring in
rxMethod
(fa45d92) causes it now to run inside aneffect
. Practically, everywithMethods
which uses
rxMethod
cannot callpatchState
anymore.I've added two tests. Once you use the new version of
rxState
from the main branch, you will see that these tests will fail.Closes #
What is the new behavior?
I played safe and reverted back to the old version. Maybe one can find a better alternative.
Does this PR introduce a breaking change?
Other information