feat(docs): Added migration and API docs for V4 #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielgek
reviewed
Apr 25, 2017
MIGRATION.md
Outdated
|
|
||
| @NgModule({ | ||
| imports: [ | ||
| StoreModule.provideStore(reducers), |
Matmo10
reviewed
Apr 25, 2017
docs/effects/api.md
Outdated
| ``` | ||
|
|
||
|
|
||
| ### Terminating Effects |
There was a problem hiding this comment.
IMO, "Terminating Effects" sounds like a way to kill an effect from running completely rather than meaning it won't automatically dispatch to the store. Maybe my terminology is just incorrect though. If not, "Preventing automatic dispatch" would be one suggestion.
There was a problem hiding this comment.
Agreed. I didn't want to call them "dead end" effects either. Maybe "Non-dispatching Effects"?
drew-moore
reviewed
Apr 25, 2017
docs/store/api.md
Outdated
| ## Feature Module State Composition | ||
|
|
||
| Store uses fractal state management, which provides state composition through feature modules, | ||
| loaded eagerly or lazily. Feature states are added using the `StoreFeature.forFeature` method. This |
brandonroberts
force-pushed
the
migration-docs
branch
from
d6eb4ec
to
1990ffc
Compare
brandonroberts
force-pushed
the
migration-docs
branch
from
1990ffc
to
1cb5541
Compare
brandonroberts
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.