-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: Add BUILD files for Schematics #954
Conversation
That issue is just about the load paths being inconsistent at runtime - it shouldn't be blocking you? |
BUILD.bazel
Outdated
@@ -7,16 +7,17 @@ exports_files([ | |||
]) | |||
|
|||
filegroup( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
note, you might want to convert this to a node_modules_filegroup
see https://github.com/bazelbuild/rules_nodejs/blob/master/defs.bzl#L41
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed. Thanks for the tip. 👍
) | ||
|
||
npm_package( | ||
name = "npm_package", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this published to npm separately from other modules?
just FYI if you need it - there is a packages
attribute on ng_package
and npm_package
that allows you to nest them if needed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, it is published separately.
@alexeagle Each schematic needs to be able to load its own What I can't seem to get working is getting these runtime config files to be in the same place at test time. It seemed like that issue was related but I may have been misconfiguring the |
168027a
to
75a3c39
Compare
Looks like this is also captured in bazelbuild/rules_typescript#154 @brandonroberts Since the tests are being run with the old runner I don't think this blocks the PR. |
@MikeRyanDev ok, will you run buildifier so linting passes? |
@MikeRyanDev I found an easy workaround with @robwormald - tell Bazel to copy the json file into bazel-bin folder so it appears in the place the
Note that Bazel frowns on having inputs at the same filesystem path as outputs, so the .json file has a different name in the source tree than it has in the bazel-bin dir. |
This does not get the tests running with Bazel. I believe we need bazelbuild/rules_nodejs#84 to be fixed first. cc @alexeagle