Improve Java6 compatibility #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unknown object reader is required for deserializing e.g. Map<String, Object> type.
zapov
reviewed
Jul 22, 2018
| } catch (InstantiationException | IllegalAccessException | InvocationTargetException e) { | ||
| throw new RuntimeException(e); | ||
| } | ||
| args -> { |
There was a problem hiding this comment.
I was converting lambdas to anonymous classes because Android was complaining about them. Shouldn't Android work now even without desugaring?
There was a problem hiding this comment.
Since 'dsl-json-java8' contains java8 byte code the desugaring is required.
zapov
reviewed
Jul 22, 2018
| return settings | ||
| public static <T> DslJson.Settings<T> withAnalyzers() { | ||
| return new DslJson.Settings() | ||
| .resolveReader(UNKNOWN_READER) |
There was a problem hiding this comment.
Did you need unknown reader for some use case?
There was a problem hiding this comment.
I mentioned that in commit message. Unknown object reader is required for deserializing e.g. Map<String, Object> type.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #66