Issue #485 - website refactor #486

organom · 2021-09-27T12:34:53Z

Polished website design
Updated social and documentation links
Quick start area refactor

Fixes #485

…. Changed thanks to poweredby. Started refactoring site content

…links. Reordered website

organom · 2021-09-28T10:01:32Z

@ilyash This sentence is not clear: If you need additional function or syntax in NGS, it's highly probable that it will be included in the language as long as it is for DevOps tasks. please provide alternative

organom · 2021-09-28T10:17:25Z

@ilyash search icon for the Language reference - please choose one from https://fontawesome.com/v5.15/icons

organom · 2021-09-28T14:25:30Z

Latest design

… new marketing-material logo location and removed .svg

ilyash

I like the top section (above logos). Very clean.
Logos are good but I would consider converting the two left to textual links.
The left two logos should open in same tab, not new - it's the same site and opening in new tab feels weird
The site breaks when width is small, especially logos section
The logos in "Quick Start" section don't feel right. Maybe smaller and/or without frames?

How do you know that site upload script would handle the directories (img)?

…site addresses by new subdomains. Added wiki link

…indow

…o normal text links and added linux+mac icons in each type of quick start. Changed theme for <a>.

organom · 2021-10-04T22:29:38Z

I like the top section (above logos). Very clean.
Logos are good but I would consider converting the two left to textual links. >>>>> would break design :'(
The left two logos should open in same tab, not new - it's the same site and opening in new tab feels weird
The site breaks when width is small, especially logos section
The logos in "Quick Start" section don't feel right. Maybe smaller and/or without frames?

How do you know that site upload script would handle the directories (img)? >>>>> With the new implementation we don't need the folder anymore, since we don't use the logos. Moved img folder into marketing_material repository to use in case we ever need that logos

organom · 2021-10-04T22:30:28Z

…factor

organom · 2021-10-06T14:15:18Z

Added meeting information. @ilyash does this fit your schedule?

Fixes #487
The issue i see with zoom is that or we use your private id, or then every week the meeting will be in a different address. I propose we try the discord meeting channel i created for that and use youtube live for recording/broadcasting. Lets try it this weekend, even if in a very fast matter :)

…m chrome

ilyash-b

Please bring back the logo to where it was. It should be served from the same domain. We don’t start using GitHub as CDN just to serve couple of files.
I have finally given some thought to the subdomains. Any redirects should not be used. It’s just worse user experience due to additional redirect. Use direct links. Additionally, some redirects are broken but it’s not important already.
Remove “_blank” targets. I think the behavior is surprising.

ilyash-b · 2021-12-21T08:41:55Z

site/index.html

            </p>
        </div>
-        <div class="col-md-3">
+    </div>
+    <div class="row pt-3 pb-3">


Yes, let's try this. Maybe on a different branch?

site/index.html

organom · 2021-12-22T17:06:14Z

Please bring back the logo to where it was. It should be served from the same domain. We don’t start using GitHub as CDN just to serve couple of files.

I have finally given some thought to the subdomains. Any redirects should not be used. It’s just worse user experience due to additional redirect. Use direct links. Additionally, some redirects are broken but it’s not important already.

Remove “_blank” targets. I think the behavior is surprising.

@ilyash Made the above requested changes. The menu as a "bar" is available in feature/website-refactor-2 branch, please let me know the one you prefer

ilyash-b · 2022-01-16T16:56:38Z

@organom , I liked and therefore merged feature/website-refactor-2

ilyash-b · 2022-01-16T17:02:20Z

@organom , please make sure that the page passes validation. Right now it doesn't.

ilyash-b · 2022-01-16T19:51:20Z

@organom , please make sure to use integrity and pinned versions in all script elements

organom · 2022-01-18T18:23:08Z

@organom , please make sure that the page passes validation. Right now it doesn't.

@ilyash-b What validator shall I use?

organom · 2022-01-19T12:15:44Z

@organom , please make sure that the page passes validation. Right now it doesn't.

@ilyash-b What validator shall I use?

Used W3C validator. Please re-review and confirm

This reverts commit c83a54f.

…to feature/website-refactor

ilyash-b · 2022-01-23T15:14:56Z

site/infra.ngs

+    REDIRECTS= [{id: "discord", host: "discord.gg", path: "6VqgcpM"},
+                {id: "videos", host: "m.youtube.com", path: "channel/UC6CL2J6syrV1mfFpxQd89gQ"},
+                {id: "source", host: "github.com", path: "ngs-lang/ngs"},
+                {id: "wiki", host: "github.com", path: "ngs-lang/ngs/wiki"},
+                {id: "ipython", host: "github.com", path: "ngs-lang/ngs-ipython-extension"},
+                {id: "docker", host: "hub.docker.com", path: "r/ngslang/ngs"},
+                {id: "brew", host: "formulae.brew.sh", path: "formula/ngs"}
+                {id: "snap", host: "snapcraft.io", path: "ngs"},
+                {id: "action", host: "github.com", path: "marketplace/actions/setup-ngs"},
+                {id: "manual", host: "ngs-lang.org", path: "doc/latest/index.html"},
+                {id: "ref", host: "ngs-lang.org", path: "doc/latest/generated/index.html"}]
+
+    REDIRECTS.each({
+        bucketName = "${A.id}.${DOMAIN}"
+        tmpbucket = AWS::Bucket(Name=bucketName).converge()
+        if not($(ok:[0, 255] aws s3api get-bucket-website --bucket ${bucketName})) {
+            tmpbucket.resources[0].run("Setting website", %(aws s3 website "s3://${bucketName}/" --index-document index.html --error-document error.html ), false)
+        }
+    })


Still relevant?

@ilyash-b maybe not all of them, but since they still exist (even if not used on the website) I would leave it. I'm at least using all the time some of them to go directly to the right place :)

organom added 5 commits September 24, 2021 13:50

Added media and documentation icons. Added code highlighting and copy…

a7f3016

…. Changed thanks to poweredby. Started refactoring site content

Refactored the install section. Cosmetics

a3b08e2

Make all links open on _blank target. Added install stores logos and …

18e0690

…links. Reordered website

Cosmetics

001a821

Changed catch phrase

ab7be5e

organom requested a review from ilyash September 27, 2021 12:34

Improved buttons design. Customized icons to fit page design.

2c3712f

organom added 2 commits September 28, 2021 12:32

Added GH-Actions logo. Refactored quick start section as per Ilya input.

a8dddc0

Fixed small screen rendering issue

6409be3

WIP: Cleanup logos on the repository - Changed readme to point to the…

dae532f

… new marketing-material logo location and removed .svg

ilyash requested changes Oct 2, 2021

View reviewed changes

ilyash and others added 6 commits October 2, 2021 17:31

exit_hook now removes hooks in child fork()

627f3d3

Added instruction on how to create the subdomains redirects. Changed …

d7546bc

…site addresses by new subdomains. Added wiki link

Improved alignment and behaviour of page icons

9b69243

Changed reference to ref. Manual and Reference now open in the same w…

ab3c2aa

…indow

Moved img folder to marketing-material repo. Changed icon-buttons int…

31fe9f6

…o normal text links and added linux+mac icons in each type of quick start. Changed theme for <a>.

Cleanup

51b37d8

organom requested a review from ilyash October 4, 2021 22:30

organom added 2 commits October 4, 2021 23:50

Merge branch 'dev' of github.com:ngs-lang/ngs into feature/website-re…

76b51fd

…factor

Added meeting information. Improved spacings

cfc9f83

organom added 4 commits October 6, 2021 15:18

Changed meeting our to fit better in the schedule

324b92d

Removed meeting endpoint

76eba9b

Added step for PR in homebrew

2b826f6

Added instructions for ngs-jupyter docker run. Fixed all warnings fro…

658331a

…m chrome

[site/index.html] Fixes and improvements

d4c71f3

ilyash-b requested changes Dec 22, 2021

View reviewed changes

organom added 2 commits December 22, 2021 16:56

Changes requested in the PR

673cb95

Reverts rest of the links to originals as per PR request

6b240d1

organom requested a review from ilyash-b December 22, 2021 17:09

Changes menu UI to a menu bar

6a8cd69

organom changed the title ~~Feature - website refactor~~ #485 - website refactor Jan 9, 2022

organom changed the title ~~#485 - website refactor~~ Issue #485 - website refactor Jan 9, 2022

[website refactor] Improve menu

f363a92

Ilya Sher added 3 commits January 16, 2022 19:12

[website refactor] Improve header

6e3f225

[website refactor] Improve header

abd0291

[website refactor] Improve

b5f8ba8

Ilya Sher and others added 2 commits January 16, 2022 22:56

[I/O] Experimenting

c83a54f

Adds missing integrity to added external scripts and styles

0f7582f

organom added 2 commits January 19, 2022 11:51

Fixed validation warnings from w3c. Improved header styling.

4b21066

Cosmetic

758be44

Ilya Sher added 3 commits January 21, 2022 23:49

Revert "[I/O] Experimenting"

9b9bfd9

This reverts commit c83a54f.

Merge branch 'feature/website-refactor' of github.com:ngs-lang/ngs in…

eba8d3a

…to feature/website-refactor

Merge branch 'dev' into feature/website-refactor

371bd11

ilyash-b reviewed Jan 23, 2022

View reviewed changes

site/ngs.png -> site/ngs-logo-300.png

d04cbfb

organom requested a review from ilyash-b January 23, 2022 15:40

ilyash-b merged commit 939bca2 into dev Jan 23, 2022

organom deleted the feature/website-refactor branch January 23, 2022 16:38

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Issue #485 - website refactor #486

Issue #485 - website refactor #486

organom commented Sep 27, 2021

organom commented Sep 28, 2021 •

edited

organom commented Sep 28, 2021

organom commented Sep 28, 2021 •

edited

ilyash left a comment

organom commented Oct 4, 2021 •

edited

organom commented Oct 4, 2021

organom commented Oct 6, 2021 •

edited

ilyash-b left a comment

ilyash-b Dec 21, 2021

organom commented Dec 22, 2021 •

edited

ilyash-b commented Jan 16, 2022

ilyash-b commented Jan 16, 2022

ilyash-b commented Jan 16, 2022

organom commented Jan 18, 2022

organom commented Jan 19, 2022

ilyash-b Jan 23, 2022

organom Jan 23, 2022

Issue #485 - website refactor #486

Issue #485 - website refactor #486

Conversation

organom commented Sep 27, 2021

organom commented Sep 28, 2021 • edited

organom commented Sep 28, 2021

organom commented Sep 28, 2021 • edited

ilyash left a comment

Choose a reason for hiding this comment

organom commented Oct 4, 2021 • edited

organom commented Oct 4, 2021

organom commented Oct 6, 2021 • edited

ilyash-b left a comment

Choose a reason for hiding this comment

ilyash-b Dec 21, 2021

Choose a reason for hiding this comment

organom commented Dec 22, 2021 • edited

ilyash-b commented Jan 16, 2022

ilyash-b commented Jan 16, 2022

ilyash-b commented Jan 16, 2022

organom commented Jan 18, 2022

organom commented Jan 19, 2022

ilyash-b Jan 23, 2022

Choose a reason for hiding this comment

organom Jan 23, 2022

Choose a reason for hiding this comment

organom commented Sep 28, 2021 •

edited

organom commented Sep 28, 2021 •

edited

organom commented Oct 4, 2021 •

edited

organom commented Oct 6, 2021 •

edited

organom commented Dec 22, 2021 •

edited