Issue #507 - improve gh actions #524
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…not default (fixes issue in centos7)
… yum external. Enforce the correct compiler
…er is too old. Try to enforce compiler version for centos:7
…kage manager is 7 and thats unfortunatly too old
ilyash-b
requested changes
Jan 11, 2022
.github/workflows/build.yml
Outdated
Comment on lines
98
to
105
| - name: Install AmazonLinux Deps | ||
| if: startsWith(matrix.container, 'amazonlinux') | ||
| run: yum -y install tar xz gzip | ||
| - name: Install CentOS Deps | ||
| if: startsWith(matrix.container, 'centos:8') | ||
| run: | | ||
| yum -y install epel-release dnf-plugins-core | ||
| yum config-manager --set-enabled powertools |
There was a problem hiding this comment.
This must be in install.sh. How people would otherwise be able to compile on these platforms?
There was a problem hiding this comment.
This is specific to centos 8 in order to allow the sources to install the compiler. Since installing the compiler is also not part of install.sh, this should also not be there.
.github/workflows/build.yml
Outdated
Comment on lines
126
to
133
| - name: Install AmazonLinux Deps | ||
| if: startsWith(matrix.container, 'amazonlinux') | ||
| run: yum -y install tar xz gzip | ||
| - name: Install CentOS Deps | ||
| if: startsWith(matrix.container, 'centos:8') | ||
| run: | | ||
| yum -y install epel-release dnf-plugins-core | ||
| yum config-manager --set-enabled powertools |
install.sh
Outdated
Comment on lines
30
to
31
| if ! command -v ctest &>/dev/null;then | ||
| if command -v ctest3 &>/dev/null;then |
There was a problem hiding this comment.
Please merge into one if if possible
There was a problem hiding this comment.
not possible, because the else case needs to happen only if inside the first if
Merged
|
Requires changes after #503 is approved, only merge/review afterwards |
|
@ilyash-b code was adapted from the changes done on the |
ilyash-b
reviewed
Jan 29, 2022
| container: [ "fedora:34", "fedora:35", "amazonlinux:2", "centos:8" ] | ||
| steps: | ||
| - name: Install AmazonLinux Deps | ||
| if: startsWith(matrix.container, 'amazonlinux') |
added 5 commits
January 29, 2022 15:11
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #507