Support pasting markdown #17

nil1511 · 2017-02-27T06:13:55Z

Added Support for pasting markdown.

How does it work?

We get the pasted text using draft-js api handlePastedText. Suppose the pasted text is

Hello World
This is _italic_
This end with *space*
* Strike
End

Every letter is iterated and push into buffer array. On encounter of oneOf(' ', '*', '_'). It push the text from buffer into editorState then work as handleBeforeInput is called then use the newEditorState and clear buffer. similarly in case of enter(return, newline) work as handleReturn is called. In case of end buffer is push into the editorState and finally the new editorState is set.

ngs · 2017-02-27T06:26:59Z

src/index.js

+        if (INLINE_STYLE_CHARACTERS.indexOf(text[i]) >= 0) {
+          newEditorState = addText(newEditorState, buffer.join('') + text[i]);
+          newEditorState = _handleCharacter(newEditorState, text[i]);
+          buffer.length = 0;


What does this line intended to?

While typing Inline transformation were taking place we space is entered.
But in case on pasting text.
"_hello_ " was transformed to hello.
But "_hello_" was not being transformed. Thus while pasting INLINE_STYLE_CHARACTERS also checked.

Thanks, that makes sense.

I meant I'm thinking assigning length property to Array instance will affect nothing.

Can I ask what intended to do in this line 148?

buffer.length = 0 will reset the array to empty without changing it's refrence thus it would work as const. Otherwise we can do let buffer = [] and buffer = [] instead of buffer.length = 0.

Updated to let version I thought buffer.length was faster. I was wrong.
https://jsperf.com/array-destroy

ngs · 2017-02-27T06:34:00Z

Can you please describe more about your changes?
Your code is not test covered, can you please write test code to cover all changes?
- Before
- After

ngs · 2017-02-27T08:12:59Z

src/index.js

@@ -1,3 +1,5 @@
+/* eslint-disable no-underscore-dangle,no-plusplus */


Can you please keep using current eslint rules?

potato4d · 2017-03-26T09:32:27Z

@ngs
At first glance the problem seems to be healed, but is there still anything else?

ngs · 2017-03-30T01:58:26Z

@potato4d @nil1511 I'm awaiting for reply about #17 (comment)

ngs · 2017-03-30T01:59:33Z

.eslintrc

-    "class-methods-use-this": 0
+    "class-methods-use-this": 0,
+    "no-plusplus":0,
+    "no-underscore-dangle":0


Can you please keep original?

fandy · 2017-04-14T08:56:55Z

Any updates on this?

nil1511 · 2017-04-15T07:21:21Z

@ngs Can you check now? Sorry for the delay.

ngs · 2017-04-15T09:38:39Z

@nil1511 Thank you. Test coverage became non-perfect with this PR.

See: https://100-75265088-gh.circle-artifacts.com/0/tmp/circle-artifacts.YP0ThHh/coverage/src/index.js.html

Could you cover non-covered lines/trees?

ngs · 2017-04-15T09:41:06Z

src/__test__/utils-test.js

+    let newEditorState = EditorState.createWithContent(Draft.convertFromRaw(newRawContentState));
+    const initialBlockSize = newEditorState.getCurrentContent().getBlockMap().size;
+    const randomBlockSize = Math.floor((Math.random() * 50) + 1); // random number bettween 1 to 50
+    for (let i = 0; i < randomBlockSize; i++) { // eslint-disable-line


Which lint rule did you disable?

no-plusplus rule

ngs · 2017-04-15T09:41:53Z

src/index.js

+      const editorState = getEditorState();
+      let newEditorState = editorState;
+      let buffer = [];
+      for (let i = 0; i < text.length; i++) { // eslint-disable-line


@nil1511 here as well

no-plusplus rule

nil1511 · 2017-04-16T05:12:08Z

@ngs Can you check the test? I have already updated the description on the first comment.

ngs · 2017-04-16T14:35:59Z

src/index.js

+const INLINE_STYLE_CHARACTERS = [' ', '*', '_'];
+
+function checkCharacterForState(editorState, character) {
+  if (INLINE_STYLE_CHARACTERS.indexOf(character) === -1) { return editorState; }


This line is not covered yet. ref

Removed it. That check was redundant. currently, checkCharacterForState is only called with one of INLINE_STYLE_CHARACTERS. Now code coverage is 100%.

ngs · 2017-04-16T17:13:56Z

@nil1511 Thank you!

* Support Pasting markdown * Fix single line paste * Reset buffer using assignment * Move eslint rules to eslintrc * Revert eslint config * Added Test case for utils * Specify disable rule * Added test case for handlePastedText * remove redundant check

ngs · 2017-04-16T18:05:03Z

Published as v0.1.0 https://www.npmjs.com/package/draft-js-markdown-shortcuts-plugin

nil1511 added 2 commits February 27, 2017 11:26

Support Pasting markdown

57e5cc4

Fix single line paste

095c92f

ngs approved these changes Feb 27, 2017

View reviewed changes

Reset buffer using assignment

c69a536

ngs requested changes Feb 27, 2017

View reviewed changes

Move eslint rules to eslintrc

0c39d6e

ngs requested changes Mar 30, 2017

View reviewed changes

nil1511 added 2 commits April 15, 2017 11:50

Revert eslint config

751e05a

Added Test case for utils

a8b2c42

ngs requested changes Apr 15, 2017

View reviewed changes

nil1511 added 2 commits April 15, 2017 15:27

Specify disable rule

663323a

Added test case for handlePastedText

463052e

ngs requested changes Apr 16, 2017

View reviewed changes

remove redundant check

3b3686e

ngs changed the base branch from master to support-paste April 16, 2017 17:13

ngs merged commit e6e09c0 into ngs:support-paste Apr 16, 2017

ngs mentioned this pull request Apr 16, 2017

Support paste #19

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Support pasting markdown #17

Support pasting markdown #17

nil1511 commented Feb 27, 2017 •

edited

Loading

ngs Feb 27, 2017

nil1511 Feb 27, 2017

ngs Feb 27, 2017

nil1511 Feb 27, 2017

nil1511 Feb 27, 2017

ngs commented Feb 27, 2017

ngs Feb 27, 2017

potato4d commented Mar 26, 2017

ngs commented Mar 30, 2017

ngs Mar 30, 2017

fandy commented Apr 14, 2017

nil1511 commented Apr 15, 2017

ngs commented Apr 15, 2017

ngs Apr 15, 2017

nil1511 Apr 15, 2017

ngs Apr 15, 2017

nil1511 Apr 15, 2017

nil1511 commented Apr 16, 2017

ngs Apr 16, 2017

nil1511 Apr 16, 2017

ngs commented Apr 16, 2017

ngs commented Apr 16, 2017

		@@ -1,3 +1,5 @@
		/* eslint-disable no-underscore-dangle,no-plusplus */

Support pasting markdown #17

Support pasting markdown #17

Conversation

nil1511 commented Feb 27, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ngs commented Feb 27, 2017

Choose a reason for hiding this comment

potato4d commented Mar 26, 2017

ngs commented Mar 30, 2017

Choose a reason for hiding this comment

fandy commented Apr 14, 2017

nil1511 commented Apr 15, 2017

ngs commented Apr 15, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

nil1511 commented Apr 16, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ngs commented Apr 16, 2017

ngs commented Apr 16, 2017

nil1511 commented Feb 27, 2017 •

edited

Loading