Fix DraftJS error when pasting over non-collapsed selection #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rosey
force-pushed
the
fix_pasting_selected_text
branch
from
547f53a
to
328381d
Compare
|
darn sorry, I had the tests passing locally but I rebased onto latest master and I think some new tests that I didn't have locally originally need fixing. 1 sec and I'll force push a fix. |
addText uses insertText, so the handlePastedText method was failing if a user was highlighting text and then pasting to replace the highlighted text. (error was: Target range must be collapsed for `insertText`) A similar method, replaceText, has been aded, and the handlePastedText method has been updated to use replaceText instead.
Rosey
force-pushed
the
fix_pasting_selected_text
branch
from
328381d
to
32f18f8
Compare
|
k should be better now 🙏 |
|
Seems great, thank you! Will publish as new patch version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
addText uses insertText, so the handlePastedText method was failing if a user
was highlighting text and then pasting to replace the highlighted text.
(error was: Target range must be collapsed for
insertText)A similar method, replaceText, has been aded, and the handlePastedText method
has been updated to use replaceText instead.