Skip to content
This repository has been archived by the owner on Mar 28, 2019. It is now read-only.

Contests can now be run for a predefined period #18

Merged
merged 2 commits into from
Jun 26, 2013

Conversation

swapagarwal
Copy link
Contributor

Start and end times of contest can be given so that admin doesn't have to worry about ending the contest manually or problems seen by users before the start time of contest. Addresses #13.

@@ -14,6 +14,7 @@
else
include('header.php');
connectdb();
date_default_timezone_set('Asia/Kolkata');
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am a bit unsure about this. Is it really necessary to set a timezone (because then we would be dependent on this Asia/Kolkata timezone only). If the timezone is not required for this to work, its great - otherwise can you get the default timezone of the server rather then setting it to Asia/Kolkata?

@ngsankha
Copy link
Owner

Hey! Great work, this should be good to merge, just take a look at the line that I have commented on. That should do it. 😄

@swapagarwal
Copy link
Contributor Author

Should i set it to utc? That way, it would be more universal.

@ngsankha
Copy link
Owner

Then the time will have to entered in UTC format in the admin page right?

If it is so, then please change it to UTC and also put a message on the admin page, at the time entry field mentioning it should be in the UTC format.

@swapagarwal
Copy link
Contributor Author

yes.. okay..

ngsankha added a commit that referenced this pull request Jun 26, 2013
Contests can now be run for a predefined period
@ngsankha ngsankha merged commit c7e47cd into ngsankha:master Jun 26, 2013
@swapagarwal
Copy link
Contributor Author

a bug fix : cf6fd38

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants