macOS fixes #24
Merged
macOS fixes #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's not supported with apple clang, and the project seems to work fine without it?
needed to build on macOS
size_t != uint64_t on macOS
|
It's entirely possible CFLAGS were just copied from scopehal without much thinking, I don't think we use openmp in here at all. This bridge was written for Linux so not surprising there's portability issues on other platforms, although they should all be solvable. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While trying to add support for the (ancient) Picoscope 5203, I stumbled upon some issues trying to build this on macOS ARM.
Where necessary, I tried to explain some of my reasoning in comments and/or commit messages.
I'm not super sure about removing -fopenmp in particular, though it seems to build fine without? All the heavy lifting seens to happen in scopehal anyway, so it's not really needed here, right? I've never worked with it before.