Clang has __popcnt for ARM #112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When binding on Windows with clang for ARM targets, `__popcnt` is defined.
zcbenz
added a commit
to zcbenz/node
that referenced
this pull request
Mar 3, 2023
zcbenz
added a commit
to zcbenz/node
that referenced
this pull request
Mar 3, 2023
zcbenz
added a commit
to zcbenz/node
that referenced
this pull request
Mar 3, 2023
zcbenz
added a commit
to zcbenz/node
that referenced
this pull request
Mar 3, 2023
zcbenz
added a commit
to zcbenz/node
that referenced
this pull request
Mar 4, 2023
|
I'm building on Windows with mingw-w64 x86_64-7.2.0 for windows and __popcnt is also missing. So, maybe cover all cases like that: "static" - so it wont interfere with ngtcp2... |
|
It would be nice to add function detection to configure and cmake scripts to handle this generally. |
|
Thank you for PR. Merged now. |
zcbenz
added a commit
to zcbenz/node
that referenced
this pull request
Mar 13, 2023
nodejs-github-bot
pushed a commit
to nodejs/node
that referenced
this pull request
Mar 19, 2023
Refs: ngtcp2/nghttp3#112 Refs: ngtcp2/ngtcp2#692 Refs: HdrHistogram/HdrHistogram_c#114 PR-URL: #47011 Refs: ngtcp2/nghttp3#112 Refs: ngtcp2/ngtcp2#692 Refs: HdrHistogram/HdrHistogram_c#114 Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
RafaelGSS
pushed a commit
to nodejs/node
that referenced
this pull request
Apr 5, 2023
Refs: ngtcp2/nghttp3#112 Refs: ngtcp2/ngtcp2#692 Refs: HdrHistogram/HdrHistogram_c#114 PR-URL: #47011 Refs: ngtcp2/nghttp3#112 Refs: ngtcp2/ngtcp2#692 Refs: HdrHistogram/HdrHistogram_c#114 Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
RafaelGSS
pushed a commit
to nodejs/node
that referenced
this pull request
Apr 7, 2023
Refs: ngtcp2/nghttp3#112 Refs: ngtcp2/ngtcp2#692 Refs: HdrHistogram/HdrHistogram_c#114 PR-URL: #47011 Refs: ngtcp2/nghttp3#112 Refs: ngtcp2/ngtcp2#692 Refs: HdrHistogram/HdrHistogram_c#114 Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
danielleadams
pushed a commit
to nodejs/node
that referenced
this pull request
Jul 6, 2023
Refs: ngtcp2/nghttp3#112 Refs: ngtcp2/ngtcp2#692 Refs: HdrHistogram/HdrHistogram_c#114 PR-URL: #47011 Refs: ngtcp2/nghttp3#112 Refs: ngtcp2/ngtcp2#692 Refs: HdrHistogram/HdrHistogram_c#114 Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When building on Windows with clang for ARM targets,
__popcntis defined.