Skip to content

Commit

Permalink
Merge pull request #859 from ngtcp2/fix-crypto-openssl-remnants
Browse files Browse the repository at this point in the history
Fix ngtcp2_crypto_openssl remnants
  • Loading branch information
tatsuhiro-t committed Jul 10, 2023
2 parents c1ac987 + 930cc72 commit 1686975
Show file tree
Hide file tree
Showing 5 changed files with 7 additions and 7 deletions.
2 changes: 1 addition & 1 deletion CMakeLists.txt
Expand Up @@ -134,7 +134,7 @@ if(HAVE_CUNIT)
add_custom_target(check COMMAND ${CMAKE_CTEST_COMMAND})
endif()

# OpenSSL (required for libngtcp2_crypto_openssl,
# OpenSSL (required for libngtcp2_crypto_quictls,
# libngtcp2_crypto_picotls and examples)
include(CheckSymbolExists)
if(ENABLE_OPENSSL AND OPENSSL_FOUND)
Expand Down
2 changes: 1 addition & 1 deletion configure.ac
Expand Up @@ -227,7 +227,7 @@ AM_CONDITIONAL([HAVE_CUNIT], [ test "x${have_cunit}" = "xyes" ])

AM_CONDITIONAL([ENABLE_SHARED], [ test "x${enable_shared}" = "xyes" ])

# OpenSSL (required for libngtcp2_crypto_openssl,
# OpenSSL (required for libngtcp2_crypto_quictls,
# libngtcp2_crypto_picotls and examples)
have_openssl=no
have_vanilla_openssl=no
Expand Down
2 changes: 1 addition & 1 deletion crypto/includes/CMakeLists.txt
Expand Up @@ -27,7 +27,7 @@ install(FILES

if(HAVE_OPENSSL)
install(FILES
ngtcp2/ngtcp2_crypto_openssl.h
ngtcp2/ngtcp2_crypto_quictls.h
DESTINATION "${CMAKE_INSTALL_INCLUDEDIR}/ngtcp2")
endif()

Expand Down
2 changes: 1 addition & 1 deletion crypto/quictls/.gitignore
@@ -1 +1 @@
/libngtcp2_crypto_openssl.pc
/libngtcp2_crypto_quictls.pc
6 changes: 3 additions & 3 deletions crypto/shared.h
Expand Up @@ -100,7 +100,7 @@ ngtcp2_crypto_ctx *ngtcp2_crypto_ctx_initial(ngtcp2_crypto_ctx *ctx);
* `ngtcp2_crypto_aead_init` initializes |aead| with the provided
* |aead_native_handle| which is an underlying AEAD object.
*
* If libngtcp2_crypto_openssl is linked, |aead_native_handle| must be
* If libngtcp2_crypto_quictls is linked, |aead_native_handle| must be
* a pointer to EVP_CIPHER.
*
* If libngtcp2_crypto_gnutls is linked, |aead_native_handle| must be
Expand Down Expand Up @@ -214,7 +214,7 @@ int ngtcp2_crypto_update_traffic_secret(uint8_t *dest, uint32_t version,
* pointed by |buf| of length |len|, to the native handle |tls|.
*
* |tls| points to a implementation dependent TLS session object. If
* libngtcp2_crypto_openssl is linked, |tls| must be a pointer to SSL
* libngtcp2_crypto_quictls is linked, |tls| must be a pointer to SSL
* object.
*
* This function returns 0 if it succeeds, or -1.
Expand All @@ -230,7 +230,7 @@ int ngtcp2_crypto_set_local_transport_params(void *tls, const uint8_t *buf,
* `ngtcp2_conn_set_remote_transport_params`.
*
* |tls| points to a implementation dependent TLS session object. If
* libngtcp2_crypto_openssl is linked, |tls| must be a pointer to SSL
* libngtcp2_crypto_quictls is linked, |tls| must be a pointer to SSL
* object.
*
* This function returns 0 if it succeeds, or -1.
Expand Down

0 comments on commit 1686975

Please sign in to comment.