The gcc builtin __builtin_clzll is not available in Windows #247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The gcc builtin __builtin_clzll is not available in Windows when building using windows.
|
Even this really isn't ideal for our case since we need to be able to build and compile on x86. Current solution on x86 is to define |
jasnell
added a commit
to jasnell/node
that referenced
this pull request
Jun 23, 2020
The ngtcp2 update uses a gcc builtin that is not available under _MSC_VER. This floats a patch to fix it. Upstream PR: ngtcp2/ngtcp2#247
jasnell
added a commit
to nodejs/node
that referenced
this pull request
Jun 24, 2020
The ngtcp2 update uses a gcc builtin that is not available under _MSC_VER. This floats a patch to fix it. Upstream PR: ngtcp2/ngtcp2#247 PR-URL: #34033 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
|
Yes, #248 should work just fine. Thank you :) |
|
Thank you. I'll merge #248 and close this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The gcc builtin __builtin_clzll is not available in Windows when building using windows.