Make crypto static library targets explicitly STATIC #919
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not having the STATIC keyword in `add_library(...)` makes CMake go look for a `BUILD_SHARED_LIBS` variable and, if set, makes the "static" library crypto targets actually create a shared library. This causes a problem if including ngtcp2 as a subproject from some other project that itself happens to have a default of true, resulting in the "static" targets getting built dynamically. This fixes it by making the crypto static library targets explicitly STATIC so that this cmake messiness doesn't happen (and also matches the way the main ngtcp2_static target is created).
jagerman
changed the title
|
Thank you for PR. Merged now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not having the STATIC keyword in
add_library(...)makes CMake go look for aBUILD_SHARED_LIBSvariable and, if set, makes the "static" library crypto targets actually create a shared library.This causes a problem if including ngtcp2 as a subproject from some other project that itself happens to have a default of
BUILD_SHARED_LIBS=ON, resulting in the "static" targets getting built dynamically.This fixes it by making the crypto static library targets explicitly STATIC so that this cmake messiness doesn't happen (and also matches the way the main ngtcp2_static target is created).