Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Add ReplaceHeader and ReplaceFooter function #3

Closed
kokizzu opened this issue Jun 15, 2016 · 5 comments
Closed

Feature Request: Add ReplaceHeader and ReplaceFooter function #3

kokizzu opened this issue Jun 15, 2016 · 5 comments

Comments

@kokizzu
Copy link

kokizzu commented Jun 15, 2016

there is a need to replace header and footer text

@AnnAddicks
Copy link
Contributor

+1 for a replace header text.

I'd be happy to help with some initial direction.

@nguyenthenguyen
Copy link
Owner

Sorry for a long time I'm not watching this repository. @AnnAddicks Could you add replace footer and some unit test ?

@AnnAddicks
Copy link
Contributor

Sure, I'd be happy to work on it; earliest time I would be able to push code would be Sunday evening.

@AnnAddicks
Copy link
Contributor

AnnAddicks commented Jul 25, 2017

Hi @nguyenthenguyen,
I just sat down to look at the footers and noticed a change to the ReplaceHeader function. If we are taking a user input for how many replaces should be done, is that per header or total? With the new changes that limits the number of changes to per header because we don't keep track of how many times it has been changed inside the loop. That is why initially I had it to not allow the user to pick a number.

I can make the footer code similar to what you have changed, but wanted to point this out. It would be a PITA to keep track per header since Replace doesn't return a count and considering some headers are for even pages and others for odd pages...I really didn't want to go down that rabbit hole.

@nguyenthenguyen
Copy link
Owner

@AnnAddicks You are right! Because we can have mutiple header, footer file. You can remove num params on ReplaceHeader and do the same for ReplaceFooter

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants