Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: 💍 convert app test to spectator and add enhance linting #3

Merged
merged 1 commit into from
Jul 21, 2020

Conversation

NachoVazquez
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

  • [ x ] The commit message follows our guidelines: CONTRIBUTING.md#commit
  • [ x ] Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ x ] Other... Please describe:
Add test and linting

What is the current behavior?

Tests on example app were running using TestBed

Issue Number: N/A

What is the new behavior?

Tests now use spectator and more strict linting rules were added.

Does this PR introduce a breaking change?

[ ] Yes
[ x ] No

Other information

@NachoVazquez NachoVazquez merged commit 1969806 into master Jul 21, 2020
@NachoVazquez NachoVazquez deleted the test/change-app-test-to-spectator branch July 21, 2020 23:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

1 participant