Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add Critical and Trace to LumberjackLogger #47

Merged
merged 4 commits into from
Nov 23, 2020

Conversation

LayZeeDK
Copy link
Member

@LayZeeDK LayZeeDK commented Nov 22, 2020

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines: CONTRIBUTING.md#commit
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

We forgot to add LumberjackLogger#createCriticalLogger and LumberjackLogger#createTraceLogger.

Issue Number: N/A

What is the new behavior?

LumberjackLogger#createCriticalLogger and LumberjackLogger#createTraceLogger are implemented.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

Added Update Chrome step to the e2e job to fix the CI pipeline.

@LayZeeDK LayZeeDK added this to Review in progress in lumberjack Nov 22, 2020
lumberjack automation moved this from Review in progress to Reviewer approved Nov 23, 2020
@NachoVazquez NachoVazquez merged commit 96c6634 into main Nov 23, 2020
lumberjack automation moved this from Reviewer approved to Done Nov 23, 2020
@NachoVazquez NachoVazquez deleted the LayZeeDK/fix/add-critical-and-trace-to-logger branch November 23, 2020 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants