-
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(spectacular)!: add required routes
option and optional testing features for provideSpectacularFeatureTest
#76
Merged
LayZeeDK
merged 13 commits into
main
from
spectacular/feat/support-feature-providers-for-feature-tests
Aug 8, 2023
Merged
feat(spectacular)!: add required routes
option and optional testing features for provideSpectacularFeatureTest
#76
LayZeeDK
merged 13 commits into
main
from
spectacular/feat/support-feature-providers-for-feature-tests
Aug 8, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6820068
to
2a8f9d8
Compare
...es/spectacular/src/lib/feature-testing/configuration/spectacular-feature-testing-features.ts
Outdated
Show resolved
Hide resolved
It is looking great; I'm excited. |
26c9eed
to
4e2e709
Compare
…to `InjectOptions`
…Harness` Common pipes are now standalone so they can be tested by passing them as options to `createPipeTestHarness`.
…ngular Testing Library
4e2e709
to
10d6fef
Compare
… features for `provideSpectacularTest` Give `provideSpectacularFeatureTest` feature-parity with `SpectacularFeatureTestingModule`. BREAKING CHANGES The required `routes` option is added to `provideSpectacularFeatureTest`.
…or of `provideSpectacularFeatureTest`
…SpectacularFeatureTesting`
… to keep backward compatibility
10d6fef
to
e639253
Compare
…ectacularFeatureTestingOptions`, and `withInitialFeatureNavigation` to readme
e639253
to
73bee63
Compare
NachoVazquez
requested changes
Aug 7, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left some small nitpicks assisted by the linter, but it looks great!
...es/spectacular/src/lib/feature-testing/configuration/spectacular-feature-testing-features.ts
Show resolved
Hide resolved
packages/spectacular/src/lib/feature-testing/configuration/with-initial-feature-navigation.ts
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Features
provideSpectacularFeatureTest
only supports thefeaturePath
optionprovideSpectacularFeatureTest
returnsProvider[]
provideSpectacularFeatureTest
is stable andprovideSpectacularFeatureTesting
does not existwithInitialFeatureNavigation
does not existSpectacularFeatureTestingModule
is stableRefactors
SpectacularFeatureTestingRootModule
usesInjectFlags
Testing
CapitalizePipe
is testedDocumentation
excludeComponentDeclaration
option is specified for all Angular Testing Library example testsIssue Number: N/A
What is the new behavior?
Features
provideSpectacularFeatureTest
requires aroutes
option and optionally accepts thewithInitialFeatureNavigation
feature and Angular Router featuresprovideSpectacularFeatureTest
returns(EnvironmentProviders | Provider)[]
provideSpectacularFeatureTest
is marked as deprecated and a copy is renamed toprovideSpectacularFeatureTesting
withInitialFeatureNavigation
for use withprovideSpectacularFeatureTest
andprovideSpectacularFeatureTesting
SpectacularFeatureTestingModule
is deprecatedRefactors
SpectacularFeatureTestingRootModule
usesInjectOptions
Testing
CapitalizePipe
are testedDocumentation
excludeComponentDeclaration
option is not mentioned in Angular Testing Library example testsDoes this PR introduce a breaking change?
BREAKING CHANGES
routes
option must be passed toprovideSpectacularFeatureTest
.provideSpectacularFeatureTest
returns(EnvironmentProviders | Provider)[]
DEPRECATIONS
provideSpectacularFeatureTest
is to be removed in Spectacular version 16. Migrate toprovideSpectacularFeatureTesting
.SpectacularFeatureTestingModule
is to be removed in Spectacular version 16. Migrate toprovideSpectacularFeatureTesting
.Other information
API design Gist