fix(core): ensure disabled prop is working for field without key (#3665)

fix #3657
ngx-formly · May 1, 2023 · 1dd5c6e · 1dd5c6e
1 parent 78ec05e
commit 1dd5c6e
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 1 deletion.
diff --git a/src/core/src/lib/extensions/field-form/field-form.spec.ts b/src/core/src/lib/extensions/field-form/field-form.spec.ts
@@ -210,6 +210,15 @@ describe('FieldFormExtension', () => {
   });
 
   describe('props disabled state', () => {
+    it('should disable field without key', () => {
+      const field = buildField({
+        props: { disabled: true },
+      });
+
+      const control = field.formControl;
+      expect(control.disabled).toBeTrue();
+    });
+
     it('should disable sub-fields when parent is disabled', () => {
       const field = buildField({
         key: 'address',

diff --git a/src/core/src/lib/extensions/field-form/field-form.ts b/src/core/src/lib/extensions/field-form/field-form.ts
@@ -61,7 +61,10 @@ export class FieldFormExtension implements FormlyExtension {
         control = new FormGroup({}, controlOptions);
       } else {
         const value = hasKey(field) ? getFieldValue(field) : field.defaultValue;
-        control = new FormControl({ value, disabled: false }, { ...controlOptions, initialValueIsDefault: true });
+        control = new FormControl(
+          { value, disabled: !!field.props.disabled },
+          { ...controlOptions, initialValueIsDefault: true },
+        );
       }
     }