fix(core): handle passing undefined to select options pipe (#3326)

ngx-formly · Jun 3, 2022 · 2299818 · 2299818
1 parent 3f45390
commit 2299818
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 10 deletions.
diff --git a/src/core/select/src/select-options.pipe.spec.ts b/src/core/select/src/select-options.pipe.spec.ts
@@ -8,6 +8,12 @@ describe('Pipe: FormlySelectOptionsPipe', () => {
     pipe = new FormlySelectOptionsPipe();
   });
 
+  it('passing empty options', () => {
+    pipe.transform(undefined).subscribe((options) => {
+      expect(options).toEqual([]);
+    });
+  });
+
   it('passing options as an array', () => {
     pipe.transform([{ label: '1', value: '1' }]).subscribe((options) => {
       expect(options).toEqual([{ label: '1', value: '1', disabled: false }]);
@@ -54,7 +60,7 @@ describe('Pipe: FormlySelectOptionsPipe', () => {
   });
 
   describe('label & value & disabled props', () => {
-    let options;
+    let options: any;
     beforeEach(() => {
       options = [{ name: 'foo', id: '1', locked: true }];
     });
@@ -76,9 +82,9 @@ describe('Pipe: FormlySelectOptionsPipe', () => {
     it('as a function', () => {
       const field = {
         props: {
-          labelProp: (item) => item.name,
-          valueProp: (item) => item.id,
-          disabledProp: (item) => item.locked,
+          labelProp: (item: any) => item.name,
+          valueProp: (item: any) => item.id,
+          disabledProp: (item: any) => item.locked,
         },
       };
 
@@ -96,10 +102,10 @@ describe('Pipe: FormlySelectOptionsPipe', () => {
 
       const field = {
         props: {
-          labelProp: (item) => item.name,
-          valueProp: (item) => item.id,
-          disabledProp: (item) => item.locked,
-          groupProp: (item) => item.parent,
+          labelProp: (item: any) => item.name,
+          valueProp: (item: any) => item.id,
+          disabledProp: (item: any) => item.locked,
+          groupProp: (item: any) => item.parent,
         },
       };
 
@@ -122,7 +128,7 @@ describe('Pipe: FormlySelectOptionsPipe', () => {
   });
 
   describe('group options', () => {
-    let options;
+    let options: any;
     beforeEach(() => {
       options = [
         { label: '1', value: '1', parent: '1' },

diff --git a/src/core/select/src/select-options.pipe.ts b/src/core/select/src/select-options.pipe.ts
@@ -40,7 +40,7 @@ export class FormlySelectOptionsPipe implements PipeTransform {
     const opts: FormlySelectOption[] = [];
     const groups: { [id: string]: number } = {};
 
-    options.forEach((option) => {
+    options?.forEach((option) => {
       const o = this.transformOption(option, to);
       if (o.group) {
         const id = groups[o.label];