fix(core): emit valueChanges when FormControl value changes (#3079)

fix #3076
ngx-formly · Dec 6, 2021 · 4bd37b8 · 4bd37b8
1 parent 9c8c3ea
commit 4bd37b8
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 1 deletion.
diff --git a/src/core/src/lib/extensions/field-form/utils.spec.ts b/src/core/src/lib/extensions/field-form/utils.spec.ts
@@ -146,6 +146,24 @@ describe('registerControl', () => {
       expect(spy).toHaveBeenCalledWith({ foo: null });
       subscription.unsubscribe();
     });
+
+    it('should emit valueChanges when FormControl value changes', () => {
+      const field = {
+        key: 'foo',
+        form: new FormGroup({}),
+        formControl: new FormControl(),
+        parent: { model: { foo: 'test' } },
+      };
+
+      const spy = jest.fn();
+      const subscription = field.formControl.valueChanges.subscribe(spy);
+
+      registerControl(field);
+
+      expect(spy).toHaveBeenCalledTimes(1);
+      expect(spy).toHaveBeenCalledWith('test');
+      subscription.unsubscribe();
+    });
   });
 });
 

diff --git a/src/core/src/lib/extensions/field-form/utils.ts b/src/core/src/lib/extensions/field-form/utils.ts
@@ -81,7 +81,7 @@ export function registerControl(field: FormlyFieldConfigCache, control?: any, em
   const paths = getKeyPath(field);
   const value = getFieldValue(field);
   if (!(isNil(control.value) && isNil(value)) && control.value !== value && control instanceof FormControl) {
-    control.patchValue(value, { emitEvent: false });
+    control.patchValue(value);
   }
 
   for (let i = 0; i < paths.length - 1; i++) {