fix(json-schema): ignore resetOnHide for array typ on build

fix #3910
ngx-formly · May 12, 2024 · fc8d6d1 · fc8d6d1
1 parent 67c6783
commit fc8d6d1
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 4 deletions.
diff --git a/src/core/json-schema/src/formly-json-schema.service.ts b/src/core/json-schema/src/formly-json-schema.service.ts
@@ -732,10 +732,12 @@ export class FormlyJsonschema {
     }
 
     let field = schema._field;
-    let model = root.model ? clone(root.model) : root.fieldArray ? [] : {};
+    let model = root.model ? root.model : root.fieldArray ? [] : {};
     if (root.model && hasKey(root)) {
       model = { [Array.isArray(root.key) ? root.key.join('.') : root.key]: getFieldValue(root) };
     }
+
+    model = clone(model);
     if (!field) {
       field = schema._field = root.options.build({
         form: Array.isArray(model) ? new FormArray([]) : new FormGroup({}),

diff --git a/src/core/src/lib/services/formly.builder.ts b/src/core/src/lib/services/formly.builder.ts
@@ -28,7 +28,9 @@ export class FormlyFormBuilder {
 
     disableTreeValidityCall(field.form, () => {
       this._build(field);
-      if (!field.parent) {
+      // TODO: add test for https://github.com/ngx-formly/ngx-formly/issues/3910
+      if (!field.parent || (field as FormlyFieldConfigCache).fieldArray) {
+        // detect changes early to avoid reset value by hidden fields
         const options = (field as FormlyFieldConfigCache).options;
         options.checkExpressions?.(field, true);
         options._detectChanges?.(field);

diff --git a/src/core/src/lib/templates/field-array.type.ts b/src/core/src/lib/templates/field-array.type.ts
@@ -65,8 +65,7 @@ export abstract class FieldArrayType<F extends FormlyFieldConfig = FieldArrayTyp
 
   private _build() {
     const fields = (this.field as FormlyFieldConfigCache).formControl._fields ?? [this.field];
-    fields.forEach((f) => this.options.build(f));
-    this.field.options.detectChanges(this.field);
+    fields.forEach((f) => (this.options as any).build(f));
     this.options.fieldChanges.next({
       field: this.field,
       value: getFieldValue(this.field),