Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom aria-labelledby in material select #1746

Closed
kapalex opened this issue Aug 28, 2019 · 3 comments · Fixed by #1748
Closed

Custom aria-labelledby in material select #1746

kapalex opened this issue Aug 28, 2019 · 3 comments · Fixed by #1748
Labels

Comments

@kapalex
Copy link

kapalex commented Aug 28, 2019

I'm submitting a ... (check one with "x")

[x] bug report => search github for a similar issue or PR before submitting
[ ] feature request
[ ] support request

Current behavior
I am trying to set attributes such as 'aria-labelledby'/'aria-label' on select box, but the value does not appear. I'm using attributes in templateOptions to set it.

Expected behavior
aria-labelledby should be replaced by the value I provide, it works well in input components.

Minimal reproduction of the problem with instructions

https://stackblitz.com/edit/ngx-formly-ui-material-kfj3oc?file=app/app.component.ts

What is the motivation / use case for changing the behavior?

ARIA properties are important and should be easy to set, only option I found currently is with attributes in templateOptions, if there is some alternative that would help as well.

  • Angular version: 7.0.X
  • Browser: all
  • Language: all
@aitboudad aitboudad added the bug label Aug 28, 2019
@kapalex
Copy link
Author

kapalex commented Aug 28, 2019

I would wager this is related to #1265

@kapalex
Copy link
Author

kapalex commented Aug 29, 2019

@aitboudad thanks for the quick fix :)

@aitboudad
Copy link
Member

released in 5.4.2 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging a pull request may close this issue.

2 participants