Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Invalid validation message class name in PrimeNG #2135

Closed
rternavskyi opened this issue Mar 9, 2020 · 1 comment · Fixed by #2136
Closed

Invalid validation message class name in PrimeNG #2135

rternavskyi opened this issue Mar 9, 2020 · 1 comment · Fixed by #2136
Labels
bug

Comments

@rternavskyi
Copy link
Contributor

Description
In Formly

<div class="ui-message ui-messages-error" *ngIf="showError">
    <formly-validation-message [field]="field"></formly-validation-message>
</div>

It must be PrimeNG-specific

<div class="ui-message ui-message-error" *ngIf="showError">
    <formly-validation-message class="ui-message-text" [field]="field"></formly-validation-message>
</div>

https://primefaces.org/primeng/showcase/#/validation
PrimeNG uses ui-message-... classes for validation and ui-messages-... classes for global ones

Environment

  • Angular version: 8.2.9
  • PrimeNG version: 8.0.4
  • Formly version: 5.0.0
  • Formly PrimeNG version: 5.5.12
@rternavskyi rternavskyi added the bug label Mar 9, 2020
@rternavskyi rternavskyi mentioned this issue Mar 10, 2020
Merged
aitboudad pushed a commit that referenced this issue Mar 12, 2020
@rternavskyi
fix(primeng): change class ui-messages-error to ui-message-error (#2136)
faa8230 
fix #2135
aitboudad pushed a commit that referenced this issue Mar 14, 2020
@rternavskyi @aitboudad
fix(primeng): change class ui-messages-error to ui-message-error (#2136)
595db69 
fix #2135
aitboudad pushed a commit that referenced this issue Mar 17, 2020
@rternavskyi @aitboudad
fix(primeng): change class ui-messages-error to ui-message-error (#2136)
1b41aaa 
fix #2135
@aitboudad
Copy link
Member

This issue has been fixed and released as part of v5.5.15 release.

Please let us know, in case you are still encountering a similar issue/problem.
Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(primeng): change class ui-messages-error to ui-message-error
2 participants
@aitboudad @rternavskyi