Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The package is incompatible with angular 13 #3049

Closed
orgads opened this issue Nov 14, 2021 · 5 comments · Fixed by #3062
Closed

The package is incompatible with angular 13 #3049

orgads opened this issue Nov 14, 2021 · 5 comments · Fixed by #3062
Labels

Comments

@orgads
Copy link

orgads commented Nov 14, 2021

Description
When @angular/core@13 is installed, require @ngx-formly/core fails with the following error:

node:internal/modules/cjs/loader:979
    throw new ERR_REQUIRE_ESM(filename, true);
    ^

Error [ERR_REQUIRE_ESM]: require() of ES Module F:\Projects\test-formly\node_modules\@angular\common\fesm2015\common.mjs not supported.
Instead change the require of F:\Projects\test-formly\node_modules\@angular\common\fesm2015\common.mjs to a dynamic import() which is available in all CommonJS modules.
    at F:\Projects\test-formly\node_modules\@ngx-formly\core\bundles\ngx-formly-core.umd.js:2:85
    at Object.<anonymous> (F:\Projects\test-formly\node_modules\@ngx-formly\core\bundles\ngx-formly-core.umd.js:5:2)
    at Object.<anonymous> (F:\Projects\test-formly\test.js:1:1) {
  code: 'ERR_REQUIRE_ESM'
}

Minimal Reproduction
bug3049.zip

Your Environment

  • Angular version: 13.0.1
  • Formly version: 5.10.23
@orgads orgads added the bug label Nov 14, 2021
@aitboudad
Copy link
Member

@orgads
Copy link
Author

orgads commented Nov 14, 2021

It's the same.

@orgads
Copy link
Author

orgads commented Nov 14, 2021

The reproduction is extremely simple:

npm i @ngx-formly/core @angular/core@13
node -r @ngx-formly/core

@aitboudad
Copy link
Member

Ok I'll check on my side once I've got the chance

aitboudad added a commit to aitboudad/ngx-formly that referenced this issue Nov 25, 2021
BREAKING CHANGE: Formly v6 now requires Angular Version >= 13

fix ngx-formly#3053, fix ngx-formly#3049, fix ngx-formly#2701
aitboudad added a commit to aitboudad/ngx-formly that referenced this issue Nov 25, 2021
BREAKING CHANGE: Formly v6 now requires Angular Version >= 13

fix ngx-formly#3053, fix ngx-formly#3049, fix ngx-formly#2701
aitboudad added a commit that referenced this issue Nov 25, 2021
BREAKING CHANGE: Formly v6 now requires Angular Version >= 13

fix #3053, fix #3049, fix #2701, fix #2958
aitboudad added a commit that referenced this issue Dec 1, 2021
BREAKING CHANGE: Formly v6 now requires Angular Version >= 13

fix #3053, fix #3049, fix #2701, fix #2958
aitboudad added a commit that referenced this issue Dec 1, 2021
BREAKING CHANGE: Formly v6 now requires Angular Version >= 13

fix #3053, fix #3049, fix #2701, fix #2958
aitboudad added a commit that referenced this issue Dec 1, 2021
BREAKING CHANGE: Formly v6 now requires Angular Version >= 13

fix #3053, fix #3049, fix #2701, fix #2958
aitboudad added a commit that referenced this issue Dec 1, 2021
BREAKING CHANGE: Formly v6 now requires Angular Version >= 13

fix #3053, fix #3049, fix #2701, fix #2958
aitboudad added a commit that referenced this issue Dec 1, 2021
BREAKING CHANGE: Formly v6 now requires Angular Version >= 13

fix #3053, fix #3049, fix #2701, fix #2958
@aitboudad
Copy link
Member

Angular v13 support is released in v6.0.0-next.4 (release), to give it a try use next tag:

ng add @ngx-formly/schematics@next --ui-theme=bootstrap

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging a pull request may close this issue.

2 participants