New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v6 FieldArrayTypeConfig does not have generic prop value #3341
Labels
Comments
Could you please send a PR? |
Sure |
4 tasks
aitboudad
pushed a commit
to dereekb/ngx-formly
that referenced
this issue
Jun 10, 2022
aitboudad
pushed a commit
that referenced
this issue
Jun 10, 2022
This issue has been fixed and released as part of v6.0.0-beta.3 release. Please let us know, in case you are still encountering a similar issue/problem. |
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description
The FieldArrayTypeConfig type does not allow for a custom props value like FormlyFieldConfig does.
Minimal Reproduction
ngx-formly/src/core/src/lib/templates/field-array.type.ts
Line 8 in a44f2a5
Your Environment
Additional context
My guess is this is an oversight, as I don't see why it couldn't be the same as FieldTypeConfig or FieldGroupTypeConfig.
ngx-formly/src/core/src/lib/templates/field.type.ts
Line 5 in a44f2a5
I'm in the process of updating from 6.0.0-next.9 and taking advantage of the changes, but noticed this type wasn't updated so I have to extend FieldArrayTypeConfig instead like I have been (posted for reference), instead of using props.
https://github.com/dereekb/dbx-components/blob/4b0699c411f04d08982947f981993a87edbe2b46/packages/dbx-form/src/lib/formly/field/value/array/array.field.component.ts#L12
The text was updated successfully, but these errors were encountered: