Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v6 FieldArrayTypeConfig does not have generic prop value #3341

Closed
dereekb opened this issue Jun 7, 2022 · 4 comments · Fixed by #3342
Closed

v6 FieldArrayTypeConfig does not have generic prop value #3341

dereekb opened this issue Jun 7, 2022 · 4 comments · Fixed by #3342
Labels

Comments

@dereekb
Copy link
Contributor

dereekb commented Jun 7, 2022

Description
The FieldArrayTypeConfig type does not allow for a custom props value like FormlyFieldConfig does.

Minimal Reproduction

export interface FieldArrayTypeConfig extends FormlyFieldConfig {

Your Environment

  • Angular version: 13.3.0
  • Formly version: 6.0.0-beta.2

Additional context
My guess is this is an oversight, as I don't see why it couldn't be the same as FieldTypeConfig or FieldGroupTypeConfig.

export interface FieldTypeConfig<T = FormlyFieldConfig['props']> extends FormlyFieldConfig<T> {

I'm in the process of updating from 6.0.0-next.9 and taking advantage of the changes, but noticed this type wasn't updated so I have to extend FieldArrayTypeConfig instead like I have been (posted for reference), instead of using props.

https://github.com/dereekb/dbx-components/blob/4b0699c411f04d08982947f981993a87edbe2b46/packages/dbx-form/src/lib/formly/field/value/array/array.field.component.ts#L12

@dereekb dereekb added the bug label Jun 7, 2022
@aitboudad
Copy link
Member

Could you please send a PR?

@dereekb
Copy link
Contributor Author

dereekb commented Jun 7, 2022

Sure

@aitboudad
Copy link
Member

This issue has been fixed and released as part of v6.0.0-beta.3 release.

Please let us know, in case you are still encountering a similar issue/problem.
Thank you!

@dereekb
Copy link
Contributor Author

dereekb commented Jun 10, 2022

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging a pull request may close this issue.

2 participants