Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): fixed FieldArrayTypeConfig props declaration #3342

Merged
merged 1 commit into from Jun 10, 2022

Conversation

dereekb
Copy link
Contributor

@dereekb dereekb commented Jun 8, 2022

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Fixes #3341.

What is the current behavior? (You can also link to an open issue here)
The FieldArrayTypeConfig type does not allow for a custom props value like FormlyFieldConfig does.

What is the new behavior (if this is a feature change)?
The FieldArrayTypeConfig type will now allow for a custom props value like FormlyFieldConfig does.

Please check if the PR fulfills these requirements

Other information:

Looks like the types for this interface were overlooked in #3295.

@netlify
Copy link

netlify bot commented Jun 8, 2022

Deploy Preview for formly-dev ready!

Name Link
🔨 Latest commit a949453
🔍 Latest deploy log https://app.netlify.com/sites/formly-dev/deploys/62a383bb27c1cf0008eaa5b5
😎 Deploy Preview https://deploy-preview-3342--formly-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@aitboudad aitboudad merged commit 7f02170 into ngx-formly:main Jun 10, 2022
@aitboudad
Copy link
Member

Thank you @dereekb!

@dereekb dereekb deleted the fix/array-typing branch June 21, 2022 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

v6 FieldArrayTypeConfig does not have generic prop value
2 participants