Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Expression "props.disabled"] Object.defineProperty called on non-object #3631

Closed
davidoween opened this issue Mar 16, 2023 · 1 comment · Fixed by #3666
Closed

[Expression "props.disabled"] Object.defineProperty called on non-object #3631

davidoween opened this issue Mar 16, 2023 · 1 comment · Fixed by #3666
Labels
bug

Comments

@davidoween
Copy link

Description

'props.disabled': 'model.user' --> fails when expression no return boolean
'props.disabled': '!!model.user' --> it is works

Minimal Reproduction

https://stackblitz.com/edit/angular-qyt5vt?file=src%2Fapp%2Fapp.component.html,src%2Fapp%2Fapp.component.ts,src%2Fapp%2Fapp.module.ts

Your Environment

  • Angular version: 13
  • Formly version: 6.1.3
@davidoween davidoween added the bug label Mar 16, 2023
aitboudad added a commit to aitboudad/ngx-formly that referenced this issue May 1, 2023
@aitboudad
fix(core): ensure observe prop is defined before calling defineProperty
3fc2b65 
fix ngx-formly#3631
@aitboudad aitboudad mentioned this issue May 1, 2023
Merged
aitboudad added a commit that referenced this issue May 1, 2023
@aitboudad
fix(core): ensure observe prop is defined before calling defineProper…
d8cafc8 
…ty (#3666)

fix #3631
@aitboudad
Copy link
Member

This issue has been fixed and released as part of v6.1.4 release.

Please let us know, in case you are still encountering a similar issue/problem.
Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(core): ensure observe prop is defined before calling defineProperty aitboudad/ngx-formly
2 participants
@aitboudad @davidoween