Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Angular Universal #53

Closed
divyakumarjain opened this issue May 30, 2016 · 3 comments
Closed

Support Angular Universal #53

divyakumarjain opened this issue May 30, 2016 · 3 comments
Assignees

Comments

@divyakumarjain
Copy link
Contributor

divyakumarjain commented May 30, 2016

https://github.com/angular/universal

I am dont think Support for Angular Universal is a priority. But I was playing formly with Universal and debugging the issues.

Seems like there are few do's and don't

  1. Should not use this.elem.nativeElement

Will document those do's and don'ts for now. So that later support for angular universal would be easy.

Let me know what everybody thinks. We can start maintaining markup file for this.

@PatrickJS
Copy link

use the renderer when interacting with this.elem.nativeElement and you should be fine

@divyakumarjain
Copy link
Contributor Author

@gdi2290 Thanks for you input. I think these input would be valuable. Are you referring to following class?

https://angular.io/docs/ts/latest/api/core/Renderer-class.html

are there any samples to look at to understand this class better.

@mohammedzamakhan
Copy link
Contributor

I have used it to add event listeners on the window sometimes, like you can see it in primeng repo

https://github.com/primefaces/primeng/blob/587510d21af456f48c1069a7b01860564fce164c/components/menu/menu.ts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

3 participants